userns: Check euid no fsuid when establishing an unprivileged uid mapping
commit27e607b81b25b9bdff690d4503917ef8bd678177
authorEric W. Biederman <ebiederm@xmission.com>
Sat, 6 Dec 2014 00:26:30 +0000 (5 18:26 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2015 18:27:48 +0000 (8 10:27 -0800)
tree08b20e219045c65672a0a06c5c0b94fcbe473f3a
parent7d9436876e6e8b1f9e1e5eeb42a6081e29aadc52
userns: Check euid no fsuid when establishing an unprivileged uid mapping

commit 80dd00a23784b384ccea049bfb3f259d3f973b9d upstream.

setresuid allows the euid to be set to any of uid, euid, suid, and
fsuid.  Therefor it is safe to allow an unprivileged user to map
their euid and use CAP_SETUID privileged with exactly that uid,
as no new credentials can be obtained.

I can not find a combination of existing system calls that allows setting
uid, euid, suid, and fsuid from the fsuid making the previous use
of fsuid for allowing unprivileged mappings a bug.

This is part of a fix for CVE-2014-8989.

Reviewed-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/user_namespace.c