| commit | 2b5c5798750180a34cb1f39cf648d8a8bceec287 | |
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | |
| Fri, 27 Jul 2018 02:58:43 +0000 (26 22:58 -0400) | ||
| committer | Mauro Carvalho Chehab <mchehab+samsung@kernel.org> | |
| Fri, 27 Jul 2018 12:11:13 +0000 (27 08:11 -0400) | ||
| tree | e61aebc09199fb5676d25cb3cb35e21e7edcc4df | treesnapshot (tar.gz zip) |
| parent | 17f330ce9e434333a98b0fbc7b6d5ddbe0cc6770 | commitdiff |
media: i2c: adv7842: Replace mdelay() with msleep() and usleep_range() in adv7842_ddr_ram_test()
adv7842_ddr_ram_test() is never called in atomic context.
It only calls from:
adv7842_ddr_ram_test() <- adv7842_command_ram_test() <- adv7842_ioctl()
adv7842_ddr_ram_test() calls mdelay() to busily wait,
which is not necessary.
mdelay() can be replaced with msleep() and usleep_range().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
adv7842_ddr_ram_test() is never called in atomic context.
It only calls from:
adv7842_ddr_ram_test() <- adv7842_command_ram_test() <- adv7842_ioctl()
adv7842_ddr_ram_test() calls mdelay() to busily wait,
which is not necessary.
mdelay() can be replaced with msleep() and usleep_range().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
| drivers/media/i2c/adv7842.c | diffblobblamehistory |