| commit | 2d8d40afd187bced0a3d056366fb58d66fe845e3 | |
| author | Eric Dumazet <edumazet@google.com> | |
| Fri, 7 Mar 2014 06:57:52 +0000 (6 22:57 -0800) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Sun, 9 Mar 2014 00:09:10 +0000 (8 19:09 -0500) | ||
| tree | c42c299205f38d9a6ab275d53de74583f56e2119 | treesnapshot (tar.gz zip) |
| parent | d85ea93ffb7e8bb6855d60c0901e4b6571689085 | commitdiff |
pkt_sched: fq: do not hold qdisc lock while allocating memory
Resizing fq hash table allocates memory while holding qdisc spinlock,
with BH disabled.
This is definitely not good, as allocation might sleep.
We can drop the lock and get it when needed, we hold RTNL so no other
changes can happen at the same time.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
Signed-off-by: David S. Miller <davem@davemloft.net>
Resizing fq hash table allocates memory while holding qdisc spinlock,
with BH disabled.
This is definitely not good, as allocation might sleep.
We can drop the lock and get it when needed, we hold RTNL so no other
changes can happen at the same time.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/sched/sch_fq.c | diffblobblamehistory |