ASoC: sun4i-codec: return error code instead of NULL when create_card fails
commit320244ac9eb66ea498b7b5b155e86946d4f47f76
authorChen-Yu Tsai <wens@csie.org>
Mon, 31 Oct 2016 06:42:09 +0000 (31 14:42 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 18 Nov 2016 09:51:52 +0000 (18 10:51 +0100)
treec4716de09a57c2f24d2a0a4f05db8a4d8e8a3295
parent2140d4fd92772a4623514a18a7dd790fc57dc004
ASoC: sun4i-codec: return error code instead of NULL when create_card fails

commit 85915b63ad8b796848f431b66c9ba5e356e722e5 upstream.

When sun4i_codec_create_card fails, we do not assign a proper error
code to the return value. The return value would be 0 from the previous
function call, or we would have bailed out sooner. This would confuse
the driver core into thinking the device probe succeeded, when in fact
it didn't, leaving various devres based resources lingering.

Make the create_card function pass back a meaningful error code, and
assign it to the return value.

Fixes: 45fb6b6f2aa3 ("ASoC: sunxi: add support for the on-chip codec on
      early Allwinner SoCs")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/sunxi/sun4i-codec.c