| commit | 3885ca785a3618593226687ced84f3f336dc3860 | |
| author | Neil Horman <nhorman@tuxdriver.com> | |
| Fri, 27 Apr 2012 10:11:49 +0000 (27 10:11 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Sat, 28 Apr 2012 06:18:48 +0000 (28 02:18 -0400) | ||
| tree | a6b5af980c1295aaeee69749d4d79d47e072321a | treesnapshot (tar.gz zip) |
| parent | cde2e9a651b76d8db36ae94cd0febc82b637e5dd | commitdiff |
drop_monitor: Make updating data->skb smp safe
Eric Dumazet pointed out to me that the drop_monitor protocol has some holes in
its smp protections. Specifically, its possible to replace data->skb while its
being written. This patch corrects that by making data->skb an rcu protected
variable. That will prevent it from being overwritten while a tracepoint is
modifying it.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: David Miller <davem@davemloft.net>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Eric Dumazet pointed out to me that the drop_monitor protocol has some holes in
its smp protections. Specifically, its possible to replace data->skb while its
being written. This patch corrects that by making data->skb an rcu protected
variable. That will prevent it from being overwritten while a tracepoint is
modifying it.
Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: David Miller <davem@davemloft.net>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/core/drop_monitor.c | diffblobblamehistory |