ROSE: prevent heap corruption with bad facilities
commit454240b948e862d912a977b91f1e9a8488ae529f
authorDan Rosenberg <drosenberg@vsecurity.com>
Sat, 19 Mar 2011 20:43:43 +0000 (19 20:43 +0000)
committerWilly Tarreau <w@1wt.eu>
Sat, 30 Apr 2011 14:53:27 +0000 (30 16:53 +0200)
treeb94977864955ae444504c4ace5f8be11e39ed39b
parentdaf9b7d4745bd385b7d2bdca05bf7e9a05838d0a
ROSE: prevent heap corruption with bad facilities

commit be20250c13f88375345ad99950190685eda51eb8 upstream.

When parsing the FAC_NATIONAL_DIGIS facilities field, it's possible for
a remote host to provide more digipeaters than expected, resulting in
heap corruption.  Check against ROSE_MAX_DIGIS to prevent overflows, and
abort facilities parsing on failure.

Additionally, when parsing the FAC_CCITT_DEST_NSAP and
FAC_CCITT_SRC_NSAP facilities fields, a remote host can provide a length
of less than 10, resulting in an underflow in a memcpy size, causing a
kernel panic due to massive heap corruption.  A length of greater than
20 results in a stack overflow of the callsign array.  Abort facilities
parsing on these invalid length values.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/rose/rose_subr.c