Fix missing sanity check in /dev/sg
commit4f5f648b4f5b008da04dcef644369b58d24ab9b6
authorAl Viro <viro@ZenIV.linux.org.uk>
Sun, 19 Feb 2017 07:15:27 +0000 (19 07:15 +0000)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 6 Mar 2017 22:31:14 +0000 (6 17:31 -0500)
tree94d8230fd7c48e9dd38bc445f86d038d6b1cd6e8
parentcfb109399f07eb9fe536659dc36e58114c3a02cb
Fix missing sanity check in /dev/sg

[ Upstream commit 137d01df511b3afe1f05499aea05f3bafc0fb221 ]

What happens is that a write to /dev/sg is given a request with non-zero
->iovec_count combined with zero ->dxfer_len.  Or with ->dxferp pointing
to an array full of empty iovecs.

Having write permission to /dev/sg shouldn't be equivalent to the
ability to trigger BUG_ON() while holding spinlocks...

Found by Dmitry Vyukov and syzkaller.

[ The BUG_ON() got changed to a WARN_ON_ONCE(), but this fixes the
  underlying issue.  - Linus ]

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/scsi/sg.c