| commit | 518547b32ab41b12c1303d12e6e15fb1621dca4c | |
| author | Nadav Amit <namit@cs.technion.ac.il> | |
| Tue, 30 Sep 2014 17:49:19 +0000 (30 20:49 +0300) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Mon, 3 Nov 2014 11:07:24 +0000 (3 12:07 +0100) | ||
| tree | a73ab7b46108c449f8a288ed1f3a2034047a47c3 | treesnapshot (tar.gz zip) |
| parent | 6bdf06625d240361e92254143a123ab432e337f8 | commitdiff |
KVM: x86: Emulator does not calculate address correctly
In long-mode, when the address size is 4 bytes, the linear address is not
truncated as the emulator mistakenly does. Instead, the offset within the
segment (the ea field) should be truncated according to the address size.
As Intel SDM says: "In 64-bit mode, the effective address components are added
and the effective address is truncated ... before adding the full 64-bit
segment base."
Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
In long-mode, when the address size is 4 bytes, the linear address is not
truncated as the emulator mistakenly does. Instead, the offset within the
segment (the ea field) should be truncated according to the address size.
As Intel SDM says: "In 64-bit mode, the effective address components are added
and the effective address is truncated ... before adding the full 64-bit
segment base."
Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| arch/x86/kvm/emulate.c | diffblobblamehistory |