| commit | 561bbe9e42cd6b0d0148ac5d36e07b90c8065fa3 | |
| author | Paul Mackerras <paulus@samba.org> | |
| Wed, 15 Apr 2009 17:25:05 +0000 (15 17:25 +0000) | ||
| committer | Greg Kroah-Hartman <gregkh@suse.de> | |
| Sat, 2 May 2009 17:24:22 +0000 (2 10:24 -0700) | ||
| tree | ee960e96e018c86609224d30f04030fe3e810b05 | treesnapshot (tar.gz zip) |
| parent | 0b4f4f3a442e731c3916bde12a77db8e90667107 | commitdiff |
powerpc: Fix data-corrupting bug in __futex_atomic_op
upstream commit: 306a82881b14d950d59e0b59a55093a07d82aa9a
Richard Henderson pointed out that the powerpc __futex_atomic_op has a
bug: it will write the wrong value if the stwcx. fails and it has to
retry the lwarx/stwcx. loop, since 'oparg' will have been overwritten
by the result from the first time around the loop. This happens
because it uses the same register for 'oparg' (an input) as it uses
for the result.
This fixes it by using separate registers for 'oparg' and 'ret'.
Cc: stable@kernel.org
Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
upstream commit: 306a82881b14d950d59e0b59a55093a07d82aa9a
Richard Henderson pointed out that the powerpc __futex_atomic_op has a
bug: it will write the wrong value if the stwcx. fails and it has to
retry the lwarx/stwcx. loop, since 'oparg' will have been overwritten
by the result from the first time around the loop. This happens
because it uses the same register for 'oparg' (an input) as it uses
for the result.
This fixes it by using separate registers for 'oparg' and 'ret'.
Cc: stable@kernel.org
Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| arch/powerpc/include/asm/futex.h | diffblobblamehistory |