| commit | 630176c5033a4ed19a0fc6608980344657ba69af | |
| author | Theodore Ts'o <tytso@mit.edu> | |
| Sun, 30 Mar 2014 14:20:01 +0000 (30 10:20 -0400) | ||
| committer | Ben Hutchings <ben@decadent.org.uk> | |
| Wed, 9 Apr 2014 01:20:44 +0000 (9 02:20 +0100) | ||
| tree | c17836439326d14eaedced9087a655e4534ede90 | treesnapshot (tar.gz zip) |
| parent | f0a9fdec2b5a1f82a72a845b09a4ff09c4e7e1ea | commitdiff |
ext4: atomically set inode->i_flags in ext4_set_inode_flags()
commit 00a1a053ebe5febcfc2ec498bd894f035ad2aa06 upstream.
Use cmpxchg() to atomically set i_flags instead of clearing out the
S_IMMUTABLE, S_APPEND, etc. flags and then setting them from the
EXT4_IMMUTABLE_FL, EXT4_APPEND_FL flags, since this opens up a race
where an immutable file has the immutable flag cleared for a brief
window of time.
Reported-by: John Sullivan <jsrhbz@kanargh.force9.co.uk>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
commit 00a1a053ebe5febcfc2ec498bd894f035ad2aa06 upstream.
Use cmpxchg() to atomically set i_flags instead of clearing out the
S_IMMUTABLE, S_APPEND, etc. flags and then setting them from the
EXT4_IMMUTABLE_FL, EXT4_APPEND_FL flags, since this opens up a race
where an immutable file has the immutable flag cleared for a brief
window of time.
Reported-by: John Sullivan <jsrhbz@kanargh.force9.co.uk>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| fs/ext4/inode.c | diffblobblamehistory | |
| include/linux/bitops.h | diffblobblamehistory |