| commit | 656e7d397516d7a961118367fe7f97004d2a2269 | |
| author | Einar Jón <tolvupostur@gmail.com> | |
| Fri, 12 Aug 2016 11:50:41 +0000 (12 13:50 +0200) | ||
| committer | Sasha Levin <alexander.levin@verizon.com> | |
| Mon, 6 Mar 2017 22:29:26 +0000 (6 17:29 -0500) | ||
| tree | be3418cc7cbc0ca91654df8c57c237f333b05630 | treesnapshot (tar.gz zip) |
| parent | de99814cbee7f39ced9900d377b6f11fa549fee6 | commitdiff |
can: c_can_pci: fix null-pointer-deref in c_can_start() - set device pointer
[ Upstream commit c97c52be78b8463ac5407f1cf1f22f8f6cf93a37 ]
The priv->device pointer for c_can_pci is never set, but it is used
without a NULL check in c_can_start(). Setting it in c_can_pci_probe()
like c_can_plat_probe() prevents c_can_pci.ko from crashing, with and
without CONFIG_PM.
This might also cause the pm_runtime_*() functions in c_can.c to
actually be executed for c_can_pci devices - they are the only other
place where priv->device is used, but they all contain a null check.
Signed-off-by: Einar Jón <tolvupostur@gmail.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
[ Upstream commit c97c52be78b8463ac5407f1cf1f22f8f6cf93a37 ]
The priv->device pointer for c_can_pci is never set, but it is used
without a NULL check in c_can_start(). Setting it in c_can_pci_probe()
like c_can_plat_probe() prevents c_can_pci.ko from crashing, with and
without CONFIG_PM.
This might also cause the pm_runtime_*() functions in c_can.c to
actually be executed for c_can_pci devices - they are the only other
place where priv->device is used, but they all contain a null check.
Signed-off-by: Einar Jón <tolvupostur@gmail.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
| drivers/net/can/c_can/c_can_pci.c | diffblobblamehistory |