| commit | 69a64658de502c8ca383fe2c5a5208f00b5844cd | |
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | |
| Fri, 27 Jul 2018 08:07:38 +0000 (27 16:07 +0800) | ||
| committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | |
| Fri, 24 Aug 2018 15:52:35 +0000 (24 08:52 -0700) | ||
| tree | 8019a3061aa13e6a5d2e8fccd81b44788e8813c4 | treesnapshot (tar.gz zip) |
| parent | 151356270b0761e455ed82bba3353fb494451555 | commitdiff |
igb: Replace mdelay() with msleep() in igb_integrated_phy_loopback()
igb_integrated_phy_loopback() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
igb_integrated_phy_loopback() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().
This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
| drivers/net/ethernet/intel/igb/igb_ethtool.c | diffblobblamehistory |