LOCKD: Fix a race when initialising nlmsvc_timeout
commit7055233b96b0337e1d918ad093af402fd32fe4ad
authorTrond Myklebust <trond.myklebust@primarydata.com>
Fri, 2 Jan 2015 20:05:25 +0000 (2 15:05 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 27 Jan 2015 16:18:58 +0000 (27 08:18 -0800)
tree6ceab22cca976786ee5e8a9b8412d6474a9c04e2
parent8e044b92a85b2445c725ce855cde351f828efc1e
LOCKD: Fix a race when initialising nlmsvc_timeout

commit 06bed7d18c2c07b3e3eeadf4bd357f6e806618cc upstream.

This commit fixes a race whereby nlmclnt_init() first starts the lockd
daemon, and then calls nlm_bind_host() with the expectation that
nlmsvc_timeout has already been initialised. Unfortunately, there is no
no synchronisation between lockd() and lockd_up() to guarantee that this
is the case.

Fix is to move the initialisation of nlmsvc_timeout into lockd_create_svc

Fixes: 9a1b6bf818e74 ("LOCKD: Don't call utsname()->nodename...")
Cc: Bruce Fields <bfields@fieldses.org>
Cc: stable@vger.kernel.org # 3.10.x
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/lockd/svc.c