net: atm: Fix potential Spectre v1 vulnerabilities
commit79bce00dfdf34eddc17f5ac73d92defdfe62106c
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 15 Apr 2019 20:57:23 +0000 (15 15:57 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 27 Apr 2019 07:34:40 +0000 (27 09:34 +0200)
treef9b2d3831ddadb523b5d124190002e4db213b941
parent489b99b95efd9d74a5a1650ac96c2f7fcf8833f5
net: atm: Fix potential Spectre v1 vulnerabilities

[ Upstream commit 899537b73557aafbdd11050b501cf54b4f5c45af ]

arg is controlled by user-space, hence leading to a potential
exploitation of the Spectre variant 1 vulnerability.

This issue was detected with the help of Smatch:

net/atm/lec.c:715 lec_mcast_attach() warn: potential spectre issue 'dev_lec' [r] (local cap)

Fix this by sanitizing arg before using it to index dev_lec.

Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].

[1] https://lore.kernel.org/lkml/20180423164740.GY17484@dhcp22.suse.cz/

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/atm/lec.c