| commit | 8ae757d09c45102b347a1bc2867f54ffc1ab8fda | |
| author | Joern Engel <joern@logfs.org> | |
| Tue, 2 Sep 2014 21:49:54 +0000 (2 17:49 -0400) | ||
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | |
| Wed, 17 Sep 2014 20:44:01 +0000 (17 13:44 -0700) | ||
| tree | 5f161b9fc869430e10864c66f3491dce6b7ecf15 | treesnapshot (tar.gz zip) |
| parent | b53b0d99d6fbf7d44330395349a895521cfdbc96 | commitdiff |
iscsi-target: avoid NULL pointer in iscsi_copy_param_list failure
In iscsi_copy_param_list() a failed iscsi_param_list memory allocation
currently invokes iscsi_release_param_list() to cleanup, and will promptly
trigger a NULL pointer dereference.
Instead, go ahead and return for the first iscsi_copy_param_list()
failure case.
Found by coverity.
Signed-off-by: Joern Engel <joern@logfs.org>
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
In iscsi_copy_param_list() a failed iscsi_param_list memory allocation
currently invokes iscsi_release_param_list() to cleanup, and will promptly
trigger a NULL pointer dereference.
Instead, go ahead and return for the first iscsi_copy_param_list()
failure case.
Found by coverity.
Signed-off-by: Joern Engel <joern@logfs.org>
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
| drivers/target/iscsi/iscsi_target_parameters.c | diffblobblamehistory |