| commit | 9c706a49d660653625d206f6972541c1f60ea2b0 | |
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | |
| Wed, 10 Aug 2016 09:44:17 +0000 (10 11:44 +0200) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Wed, 10 Aug 2016 21:04:23 +0000 (10 14:04 -0700) | ||
| tree | fd524586607f08d65224d3bb0a3e175c8e47f1e2 | treesnapshot (tar.gz zip) |
| parent | 0184165b2f42c4b032da9dd11546bfbaeb5afd4e | commitdiff |
net: ipconfig: fix use after free
ic_close_devs() calls kfree() for all devices's ic_device. Since commit
2647cffb2bc6 ("net: ipconfig: Support using "delayed" DHCP replies")
the active device's ic_device is still used however to print the
ipconfig summary which results in an oops if the memory is already
changed. So delay freeing until after the autoconfig results are
reported.
Fixes: 2647cffb2bc6 ("net: ipconfig: Support using "delayed" DHCP replies")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
ic_close_devs() calls kfree() for all devices's ic_device. Since commit
2647cffb2bc6 ("net: ipconfig: Support using "delayed" DHCP replies")
the active device's ic_device is still used however to print the
ipconfig summary which results in an oops if the memory is already
changed. So delay freeing until after the autoconfig results are
reported.
Fixes: 2647cffb2bc6 ("net: ipconfig: Support using "delayed" DHCP replies")
Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
| net/ipv4/ipconfig.c | diffblobblamehistory |