| commit | a2d8737d5c781d388b553dd085b56d7295fffc6c | |
| author | Eric Biggers <ebiggers@google.com> | |
| Fri, 8 Dec 2017 15:13:27 +0000 (8 15:13 +0000) | ||
| committer | David Howells <dhowells@redhat.com> | |
| Fri, 8 Dec 2017 15:13:27 +0000 (8 15:13 +0000) | ||
| tree | e1a015e62fcb62ea4b6c1a3993e0dcbf415cffc5 | treesnapshot (tar.gz zip) |
| parent | fd6d2e506ce6f850d45342a15c896591291b77b5 | commitdiff |
KEYS: remove unnecessary get/put of explicit dest_keyring
In request_key_and_link(), in the case where the dest_keyring was
explicitly specified, there is no need to get another reference to
dest_keyring before calling key_link(), then drop it afterwards. This
is because by definition, we already have a reference to dest_keyring.
This change is useful because we'll be making
construct_get_dest_keyring() able to return an error code, and we don't
want to have to handle that error here for no reason.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
In request_key_and_link(), in the case where the dest_keyring was
explicitly specified, there is no need to get another reference to
dest_keyring before calling key_link(), then drop it afterwards. This
is because by definition, we already have a reference to dest_keyring.
This change is useful because we'll be making
construct_get_dest_keyring() able to return an error code, and we don't
want to have to handle that error here for no reason.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
| security/keys/request_key.c | diffblobblamehistory |