| commit | a746b578d8406b2db0e9f0d040061bc1f78433cf | |
| author | Roel Kluin <roel.kluin@gmail.com> | |
| Tue, 24 Feb 2009 18:19:48 +0000 (24 19:19 +0100) | ||
| committer | Jean Delvare <khali@linux-fr.org> | |
| Tue, 24 Feb 2009 18:19:48 +0000 (24 19:19 +0100) | ||
| tree | ce79fc247342fa9fde8ad184a4ec39d70ce0012a | treesnapshot (tar.gz zip) |
| parent | f29d2e0275a4f03ef2fd158e484508dcb0c64efb | commitdiff |
i2c: Timeouts reach -1
With a postfix decrement these timeouts reach -1 rather than 0, but
after the loop it is tested whether they have become 0.
As pointed out by Jean Delvare, the condition we are waiting for should
also be tested before the timeout. With the current order, you could
exit with a timeout error while the job is actually done.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
With a postfix decrement these timeouts reach -1 rather than 0, but
after the loop it is tested whether they have become 0.
As pointed out by Jean Delvare, the condition we are waiting for should
also be tested before the timeout. With the current order, you could
exit with a timeout error while the job is actually done.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
| drivers/i2c/busses/i2c-amd8111.c | diffblobblamehistory | |
| drivers/i2c/busses/i2c-pxa.c | diffblobblamehistory |