| commit | aa2be9b3d6d2d699e9ca7cbfc00867c80e5da213 | |
| author | Daniel Axtens <dja@axtens.net> | |
| Fri, 3 Mar 2017 06:56:55 +0000 (3 17:56 +1100) | ||
| committer | Herbert Xu <herbert@gondor.apana.org.au> | |
| Wed, 8 Mar 2017 06:01:08 +0000 (8 14:01 +0800) | ||
| tree | ea6b7359f59fed7a763df730a96f2a6cca95db14 | treesnapshot (tar.gz zip) |
| parent | c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201 | commitdiff |
crypto: powerpc - Fix initialisation of crc32c context
Turning on crypto self-tests on a POWER8 shows:
alg: hash: Test 1 failed for crc32c-vpmsum
00000000: ff ff ff ff
Comparing the code with the Intel CRC32c implementation on which
ours is based shows that we are doing an init with 0, not ~0
as CRC32c requires.
This probably wasn't caught because btrfs does its own weird
open-coded initialisation.
Initialise our internal context to ~0 on init.
This makes the self-tests pass, and btrfs continues to work.
Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
Cc: Anton Blanchard <anton@samba.org>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Axtens <dja@axtens.net>
Acked-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Turning on crypto self-tests on a POWER8 shows:
alg: hash: Test 1 failed for crc32c-vpmsum
00000000: ff ff ff ff
Comparing the code with the Intel CRC32c implementation on which
ours is based shows that we are doing an init with 0, not ~0
as CRC32c requires.
This probably wasn't caught because btrfs does its own weird
open-coded initialisation.
Initialise our internal context to ~0 on init.
This makes the self-tests pass, and btrfs continues to work.
Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
Cc: Anton Blanchard <anton@samba.org>
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Axtens <dja@axtens.net>
Acked-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| arch/powerpc/crypto/crc32c-vpmsum_glue.c | diffblobblamehistory |