| commit | ae593067dbed83010fee8ad59bab7948f3d3601f | |
| author | Eric Dumazet <edumazet@google.com> | |
| Thu, 21 Feb 2013 12:18:52 +0000 (21 12:18 +0000) | ||
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| Thu, 28 Feb 2013 14:32:27 +0000 (28 06:32 -0800) | ||
| tree | eb6f227197dbfc218c7f12f7757a56cd644a9524 | treesnapshot (tar.gz zip) |
| parent | b18383129b00d2d6aac160f55e27c5ba1cf9d49b | commitdiff |
ipv6: use a stronger hash for tcp
[ Upstream commit 08dcdbf6a7b9d14c2302c5bd0c5390ddf122f664 ]
It looks like its possible to open thousands of TCP IPv6
sessions on a server, all landing in a single slot of TCP hash
table. Incoming packets have to lookup sockets in a very
long list.
We should hash all bits from foreign IPv6 addresses, using
a salt and hash mix, not a simple XOR.
inet6_ehashfn() can also separately use the ports, instead
of xoring them.
Reported-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
[ Upstream commit 08dcdbf6a7b9d14c2302c5bd0c5390ddf122f664 ]
It looks like its possible to open thousands of TCP IPv6
sessions on a server, all landing in a single slot of TCP hash
table. Incoming packets have to lookup sockets in a very
long list.
We should hash all bits from foreign IPv6 addresses, using
a salt and hash mix, not a simple XOR.
inet6_ehashfn() can also separately use the ports, instead
of xoring them.
Reported-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| include/net/inet6_hashtables.h | diffblobblamehistory | |
| include/net/inet_sock.h | diffblobblamehistory | |
| include/net/ipv6.h | diffblobblamehistory | |
| net/ipv4/af_inet.c | diffblobblamehistory |