| commit | af25756de972d0f05246f9e6869f395ee0302c02 | |
| author | Dan Carpenter <dan.carpenter@oracle.com> | |
| Wed, 30 Nov 2016 19:36:48 +0000 (30 22:36 +0300) | ||
| committer | Martin K. Petersen <martin.petersen@oracle.com> | |
| Thu, 1 Dec 2016 00:53:58 +0000 (30 19:53 -0500) | ||
| tree | 54936fcb42ec305dfeca62e25571b3217a1fa137 | treesnapshot (tar.gz zip) |
| parent | fe7f96982a4e7103ffab45fba34c57ee19b62639 | commitdiff |
scsi: dpt_i2o: double free on error path
We recently introduced a kfree() in the caller for this function.
That's where, logically, you would think the kfree() should be.
Unfortunately the code was just ugly and not buggy so the static checker
warning was a false postive and introduced a double free.
I've removed the old kfree() and left the new one.
Fixes: 021e2927586d ("scsi: dpt_i2o: Add a missing call to kfree")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
We recently introduced a kfree() in the caller for this function.
That's where, logically, you would think the kfree() should be.
Unfortunately the code was just ugly and not buggy so the static checker
warning was a false postive and introduced a double free.
I've removed the old kfree() and left the new one.
Fixes: 021e2927586d ("scsi: dpt_i2o: Add a missing call to kfree")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Quentin Lambert <lambert.quentin@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| drivers/scsi/dpt_i2o.c | diffblobblamehistory |