| commit | ba87977a49913129962af8ac35b0e13e0fa4382d | |
| author | Ivan Vecera <ivecera@redhat.com> | |
| Fri, 19 Jan 2018 08:18:54 +0000 (19 09:18 +0100) | ||
| committer | Al Viro <viro@zeniv.linux.org.uk> | |
| Fri, 19 Jan 2018 17:19:13 +0000 (19 12:19 -0500) | ||
| tree | 7d4fb7e45ea098b47afdfb57556d041fc91ed33f | treesnapshot (tar.gz zip) |
| parent | ce4bb04cae8924792ed92f4af2793b77fc986f0e | commitdiff |
kernfs: fix regression in kernfs_fop_write caused by wrong type
Commit b7ce40cff0b9 ("kernfs: cache atomic_write_len in
kernfs_open_file") changes type of local variable 'len' from ssize_t
to size_t. This change caused that the *ppos value is updated also
when the previous write callback failed.
Mentioned snippet:
...
len = ops->write(...); <- return value can be negative
...
if (len > 0) <- true here in this case
*ppos += len;
...
Fixes: b7ce40cff0b9 ("kernfs: cache atomic_write_len in kernfs_open_file")
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Commit b7ce40cff0b9 ("kernfs: cache atomic_write_len in
kernfs_open_file") changes type of local variable 'len' from ssize_t
to size_t. This change caused that the *ppos value is updated also
when the previous write callback failed.
Mentioned snippet:
...
len = ops->write(...); <- return value can be negative
...
if (len > 0) <- true here in this case
*ppos += len;
...
Fixes: b7ce40cff0b9 ("kernfs: cache atomic_write_len in kernfs_open_file")
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
| fs/kernfs/file.c | diffblobblamehistory |