| commit | bd83a4ab569ddfc71a82fb0dd002f353b67df7df | |
| author | Sudip Mukherjee <sudipm.mukherjee@gmail.com> | |
| Sat, 30 Apr 2016 16:13:20 +0000 (30 17:13 +0100) | ||
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| Sat, 30 Apr 2016 21:04:45 +0000 (30 14:04 -0700) | ||
| tree | c812c9d780a1a8d17199c421170ad21b1a93f7de | treesnapshot (tar.gz zip) |
| parent | ea37a6b8a0b9fbe3f85b4b9da3206c28f1de6f8e | commitdiff |
char: xillybus: use devm_add_action_or_reset
If devm_add_action() fails we are explicitly calling dma_unmap_single(),
pci_unmap_single() and kfree(). Lets use the helper
devm_add_action_or_reset() and return directly in case of error, as we
know that the cleanup function has been already called by the helper if
there was any error. At that same time remove the variable rc which
becomes unused now.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
If devm_add_action() fails we are explicitly calling dma_unmap_single(),
pci_unmap_single() and kfree(). Lets use the helper
devm_add_action_or_reset() and return directly in case of error, as we
know that the cleanup function has been already called by the helper if
there was any error. At that same time remove the variable rc which
becomes unused now.
Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| drivers/char/xillybus/xillybus_of.c | diffblobblamehistory | |
| drivers/char/xillybus/xillybus_pcie.c | diffblobblamehistory |