| commit | ca18a852ee3696ea625efa13b1fac3c33f025a53 | |
| author | Geert Uytterhoeven <geert+renesas@glider.be> | |
| Mon, 2 Mar 2020 08:24:48 +0000 (2 09:24 +0100) | ||
| committer | Linus Walleij <linus.walleij@linaro.org> | |
| Tue, 3 Mar 2020 12:33:02 +0000 (3 13:33 +0100) | ||
| tree | 16b25f36b019e37b7db444db6bc3adc22a958d82 | treesnapshot (tar.gz zip) |
| parent | 869233f81337bfb33c79f1e7539147d52c0ba383 | commitdiff |
gpiolib: Fix inverted check in gpiochip_remove()
The optimization to check for requested lines actually optimized for the
uncomon error case, where one of the GPIO lines is still in use.
Hence the error message must be printed when the loop is terminated
early, not when it went through all available GPIO lines.
Fixes: 869233f81337bfb3 ("gpiolib: Optimize gpiochip_remove() when check for requested line")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20200302082448.11795-1-geert+renesas@glider.be
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
The optimization to check for requested lines actually optimized for the
uncomon error case, where one of the GPIO lines is still in use.
Hence the error message must be printed when the loop is terminated
early, not when it went through all available GPIO lines.
Fixes: 869233f81337bfb3 ("gpiolib: Optimize gpiochip_remove() when check for requested line")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20200302082448.11795-1-geert+renesas@glider.be
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| drivers/gpio/gpiolib.c | diffblobblamehistory |