| commit | d0905ca757bc40bd1ebc261a448a521b064777d7 | |
| author | Andy Grover <agrover@redhat.com> | |
| Tue, 22 Nov 2016 00:35:30 +0000 (21 16:35 -0800) | ||
| committer | Bart Van Assche <bart.vanassche@sandisk.com> | |
| Thu, 15 Dec 2016 15:34:58 +0000 (15 16:34 +0100) | ||
| tree | b1a44e58386d0be4b2d49534dcac50c7e36b29ac | treesnapshot (tar.gz zip) |
| parent | 8dcf07be2d0bcbfcebc49b9451a4feaf83e3428b | commitdiff |
target/user: Fix use-after-free of tcmu_cmds if they are expired
Don't free the cmd in tcmu_check_expired_cmd, it's still referenced by
an entry in our cmd_id->cmd idr. If userspace ever resumes processing,
tcmu_handle_completions() will use the now-invalid cmd pointer.
Instead, don't free cmd. It will be freed by tcmu_handle_completion() if
userspace ever recovers, or tcmu_free_device if not.
Cc: stable@vger.kernel.org
Reported-by: Bryant G Ly <bgly@us.ibm.com>
Tested-by: Bryant G Ly <bgly@us.ibm.com>
Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Don't free the cmd in tcmu_check_expired_cmd, it's still referenced by
an entry in our cmd_id->cmd idr. If userspace ever resumes processing,
tcmu_handle_completions() will use the now-invalid cmd pointer.
Instead, don't free cmd. It will be freed by tcmu_handle_completion() if
userspace ever recovers, or tcmu_free_device if not.
Cc: stable@vger.kernel.org
Reported-by: Bryant G Ly <bgly@us.ibm.com>
Tested-by: Bryant G Ly <bgly@us.ibm.com>
Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
| drivers/target/target_core_user.c | diffblobblamehistory |