SCSI: fix crashes in sd and sr runtime PM
commitd1c3daf2f290d206bb3d1a5b2f0fa1871c4987d3
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 20 Jan 2016 16:26:01 +0000 (20 11:26 -0500)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 15 Feb 2016 20:42:32 +0000 (15 15:42 -0500)
tree37b1ea1b21723969c85650e72352ae087074f505
parentabde0bf5ce77f28164ae4623eec3fad63619d9a9
SCSI: fix crashes in sd and sr runtime PM

[ Upstream commit 13b4389143413a1f18127c07f72c74cad5b563e8 ]

Runtime suspend during driver probe and removal can cause problems.
The driver's runtime_suspend or runtime_resume callbacks may invoked
before the driver has finished binding to the device or after the
driver has unbound from the device.

This problem shows up with the sd and sr drivers, and can cause disk
or CD/DVD drives to become unusable as a result.  The fix is simple.
The drivers store a pointer to the scsi_disk or scsi_cd structure as
their private device data when probing is finished, so we simply have
to be sure to clear the private data during removal and test it during
runtime suspend/resume.

This fixes <https://bugs.debian.org/801925>.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Paul Menzel <paul.menzel@giantmonkey.de>
Reported-by: Erich Schubert <erich@debian.org>
Reported-by: Alexandre Rossi <alexandre.rossi@gmail.com>
Tested-by: Paul Menzel <paul.menzel@giantmonkey.de>
Tested-by: Erich Schubert <erich@debian.org>
CC: <stable@vger.kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/scsi/sd.c
drivers/scsi/sr.c