| commit | d723a92dd465d549bf79dd481c09d59f0be02936 | |
| author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | |
| Thu, 10 Oct 2013 07:03:55 +0000 (10 18:03 +1100) | ||
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| Mon, 14 Oct 2013 17:07:19 +0000 (14 10:07 -0700) | ||
| tree | 70a30da992a8d620b4a2efec65cc94f07906b425 | treesnapshot (tar.gz zip) |
| parent | 785a162d147a547bc7a577c1c28f6fb9dbeb4f16 | commitdiff |
sysfs/bin: Fix size handling overflow for bin_attribute
While looking at the code, I noticed that bin_attribute read() and write()
ops copy the inode size into an int for futher comparisons.
Some bin_attributes can be fairly large. For example, pci creates some for
BARs set to the BAR size and giant BARs are around the corner, so this is
going to break something somewhere eventually.
Let's use the right type.
[adjust for seqfile conversions, only needed for bin_read() - gkh]
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
While looking at the code, I noticed that bin_attribute read() and write()
ops copy the inode size into an int for futher comparisons.
Some bin_attributes can be fairly large. For example, pci creates some for
BARs set to the BAR size and giant BARs are around the corner, so this is
going to break something somewhere eventually.
Let's use the right type.
[adjust for seqfile conversions, only needed for bin_read() - gkh]
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| fs/sysfs/file.c | diffblobblamehistory |