btrfs: always reserve our entire size for the global reserve
commitd792b0f197116b7093c119df29cb174ccfde94b9
authorJosef Bacik <josef@toxicpanda.com>
Thu, 22 Aug 2019 19:19:01 +0000 (22 15:19 -0400)
committerDavid Sterba <dsterba@suse.com>
Mon, 9 Sep 2019 12:59:19 +0000 (9 14:59 +0200)
tree86b548fcaef8f0534d936318bc1cffffe64cce66
parent3593ce30b5b4a8fbe84dd1c275e9be01af28511a
btrfs: always reserve our entire size for the global reserve

While messing with the overcommit logic I noticed that sometimes we'd
ENOSPC out when really we should have run out of space much earlier.  It
turns out it's because we'll only reserve up to the free amount left in
the space info for the global reserve, but that doesn't make sense with
overcommit because we could be well above our actual size.  This results
in the global reserve not carving out it's entire reservation, and thus
not putting enough pressure on the rest of the infrastructure to do the
right thing and ENOSPC out at a convenient time.  Fix this by always
taking our full reservation amount for the global reserve.

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/block-rsv.c