| commit | dbe8ccc27ee453e435597e636b4c7445fdc8c6d5 | |
| author | Takashi Iwai <tiwai@suse.de> | |
| Tue, 9 Feb 2016 09:23:52 +0000 (9 10:23 +0100) | ||
| committer | Sasha Levin <sasha.levin@oracle.com> | |
| Fri, 4 Mar 2016 15:25:39 +0000 (4 10:25 -0500) | ||
| tree | ca2eacc037711d795ff403d2546dfe2aa0bc4d35 | treesnapshot (tar.gz zip) |
| parent | 9b7283948d5f83ac692ed0243e17e2f1d3843c6c | commitdiff |
ALSA: hda - Fix bad dereference of jack object
[ Upstream commit 2ebab40eb74a0225d5dfba72bfae317dd948fa2d ]
The hda_jack_tbl entries are managed by snd_array for allowing
multiple jacks. It's good per se, but the problem is that struct
hda_jack_callback keeps the hda_jack_tbl pointer. Since snd_array
doesn't preserve each pointer at resizing the array, we can't keep the
original pointer but have to deduce the pointer at each time via
snd_array_entry() instead. Actually, this resulted in the deference
to the wrong pointer on codecs that have many pins such as CS4208.
This patch replaces the pointer to the NID value as the search key.
As an unexpected good side effect, this even simplifies the code, as
only NID is needed in most cases.
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
[ Upstream commit 2ebab40eb74a0225d5dfba72bfae317dd948fa2d ]
The hda_jack_tbl entries are managed by snd_array for allowing
multiple jacks. It's good per se, but the problem is that struct
hda_jack_callback keeps the hda_jack_tbl pointer. Since snd_array
doesn't preserve each pointer at resizing the array, we can't keep the
original pointer but have to deduce the pointer at each time via
snd_array_entry() instead. Actually, this resulted in the deference
to the wrong pointer on codecs that have many pins such as CS4208.
This patch replaces the pointer to the NID value as the search key.
As an unexpected good side effect, this even simplifies the code, as
only NID is needed in most cases.
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>