| commit | dfdb3be43ef1195c491e6c3760b922acb52e3575 | |
| author | Colin Ian King <colin.king@canonical.com> | |
| Tue, 21 Aug 2018 11:55:19 +0000 (21 12:55 +0100) | ||
| committer | Rob Clark <robdclark@gmail.com> | |
| Thu, 4 Oct 2018 00:24:54 +0000 (3 20:24 -0400) | ||
| tree | 3894b00903746fbcb34fe77db254d086105038f0 | treesnapshot (tar.gz zip) |
| parent | f8fc924e088ef49da5ab99a227d176facf47c25c | commitdiff |
drm/msm: fix unsigned comparison with less than zero
The return from the call to _mixer_stages can be a negative error
code however this is being assigned to an unsigned variable 'stages'
hence the check is always false. Fix this by making 'stages' an
int.
Detected by Coccinelle ("Unsigned expression compared with zero:
stages < 0")
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
The return from the call to _mixer_stages can be a negative error
code however this is being assigned to an unsigned variable 'stages'
hence the check is always false. Fix this by making 'stages' an
int.
Detected by Coccinelle ("Unsigned expression compared with zero:
stages < 0")
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rob Clark <robdclark@gmail.com>
| drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | diffblobblamehistory |