USB: serial: quatech2: fix use-after-free in probe error path
commitdff7ce1631950403507b6ae255f3eae840af8d91
authorJohan Hovold <johan@kernel.org>
Sun, 8 May 2016 18:08:02 +0000 (8 20:08 +0200)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 6 Jun 2016 23:11:01 +0000 (6 19:11 -0400)
tree3a97fc50ab945bfd1939110be6648fdbd4c84107
parentaa1ebad287b62b6fd53e3390f2d6cc261f0459bd
USB: serial: quatech2: fix use-after-free in probe error path

[ Upstream commit 028c49f5e02a257c94129cd815f7c8485f51d4ef ]

The interface read URB is submitted in attach, but was only unlinked by
the driver at disconnect.

In case of a late probe error (e.g. due to failed minor allocation),
disconnect is never called and we would end up with active URBs for an
unbound interface. This in turn could lead to deallocated memory being
dereferenced in the completion callback.

Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver")
Cc: stable <stable@vger.kernel.org> # v3.5: 40d04738491d
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/usb/serial/quatech2.c