| commit | e519869af368fe1da218b43bdb3a553d66f4fcd0 | |
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | |
| Tue, 16 Oct 2018 17:35:11 +0000 (16 19:35 +0200) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Thu, 18 Oct 2018 05:08:55 +0000 (17 22:08 -0700) | ||
| tree | 5509b9ce22e3653022ab50d415a75d39a596238f | treesnapshot (tar.gz zip) |
| parent | 33c4368ee2589c165aebd8d388cbd91e9adb9688 | commitdiff |
net: phy: mscc: fix signedness bug in vsc85xx_downshift_get
Currently, the error handling for the call to function
phy_read_paged() doesn't work because *reg_val* is of
type u16 (16 bits, unsigned), which makes it impossible
for it to hold a value less than 0.
Fix this by changing the type of variable *reg_val* to int.
Addresses-Coverity-ID: 1473970 ("Unsigned compared against 0")
Fixes: 6a0bfbbe20b0 ("net: phy: mscc: migrate to phy_select/restore_page functions")
Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Currently, the error handling for the call to function
phy_read_paged() doesn't work because *reg_val* is of
type u16 (16 bits, unsigned), which makes it impossible
for it to hold a value less than 0.
Fix this by changing the type of variable *reg_val* to int.
Addresses-Coverity-ID: 1473970 ("Unsigned compared against 0")
Fixes: 6a0bfbbe20b0 ("net: phy: mscc: migrate to phy_select/restore_page functions")
Reviewed-by: Quentin Schulz <quentin.schulz@bootlin.com>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/phy/mscc.c | diffblobblamehistory |