sg: disable interrupts inside sg_copy_buffer
commite568b3605f6f6ad1e9cbe37231cf5b578ff16d4b
authorFUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Fri, 12 Sep 2008 16:16:45 +0000 (13 01:16 +0900)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Oct 2008 03:22:58 +0000 (8 20:22 -0700)
tree6a88f01f46ccc4d7dd8918597f3f56cba73b5378
parent2e8e9ac3bd989d4a654b7750e04a6ce5f60b0dc5
sg: disable interrupts inside sg_copy_buffer

This is the backport of the upstream commit 50bed2e2862a8f3a4f7d683d0d27292e71ef18b9

The callers of sg_copy_buffer must disable interrupts before calling
it (since it uses kmap_atomic). Some callers use it on
interrupt-disabled code but some need to take the trouble to disable
interrupts just for this. No wonder they forget about it and we hit a
bug like:

http://bugzilla.kernel.org/show_bug.cgi?id=11529

James said that it might be better to disable interrupts inside the
function rather than risk the callers getting it wrong.

Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
lib/scatterlist.c