| commit | e8108866cac5058ae5aff5fa601f91bda29128f2 | |
| author | Kees Cook <keescook@chromium.org> | |
| Mon, 20 May 2019 22:37:48 +0000 (20 15:37 -0700) | ||
| committer | Shuah Khan <skhan@linuxfoundation.org> | |
| Tue, 21 May 2019 15:24:30 +0000 (21 09:24 -0600) | ||
| tree | fc1775d5db653f41cc738d9949d679362a6d8796 | treesnapshot (tar.gz zip) |
| parent | a20d452a2db7e092a9b214976306a36857b88ade | commitdiff |
selftests: Remove forced unbuffering for test running
As it turns out, the "stdbuf" command will actually force all
subprocesses into unbuffered output, and some implementations of "echo"
turn into single-character writes, which utterly wrecks writes to /sys
and /proc files.
Instead, drop the "stdbuf" usage, and for any tests that want explicit
flushing between newlines, they'll have to add "fflush(stdout);" as
needed.
Reported-by: Takashi Iwai <tiwai@suse.de>
Fixes: 5c069b6dedef ("selftests: Move test output to diagnostic lines")
Signed-off-by: Kees Cook <keescook@chromium.org>
Tested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
As it turns out, the "stdbuf" command will actually force all
subprocesses into unbuffered output, and some implementations of "echo"
turn into single-character writes, which utterly wrecks writes to /sys
and /proc files.
Instead, drop the "stdbuf" usage, and for any tests that want explicit
flushing between newlines, they'll have to add "fflush(stdout);" as
needed.
Reported-by: Takashi Iwai <tiwai@suse.de>
Fixes: 5c069b6dedef ("selftests: Move test output to diagnostic lines")
Signed-off-by: Kees Cook <keescook@chromium.org>
Tested-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
| tools/testing/selftests/kselftest/runner.sh | diffblobblamehistory |