| commit | f048fa9c8686119c3858a463cab6121dced7c0bf | |
| author | Michael Chan <mchan@broadcom.com> | |
| Tue, 1 Jun 2010 15:05:36 +0000 (1 15:05 +0000) | ||
| committer | David S. Miller <davem@davemloft.net> | |
| Wed, 2 Jun 2010 09:26:40 +0000 (2 02:26 -0700) | ||
| tree | c68dd0cc095559c348c8916b6e3372b4e0610e9a | treesnapshot (tar.gz zip) |
| parent | fafeeb6c80e3842c6dc19d05de09a23f23eef0d8 | commitdiff |
bnx2: Fix hang during rmmod bnx2.
The regression is caused by:
commit 4327ba435a56ada13eedf3eb332e583c7a0586a9
bnx2: Fix netpoll crash.
If ->open() and ->close() are called multiple times, the same napi structs
will be added to dev->napi_list multiple times, corrupting the dev->napi_list.
This causes free_netdev() to hang during rmmod.
We fix this by calling netif_napi_del() during ->close().
Also, bnx2_init_napi() must not be in the __devinit section since it is
called by ->open().
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
The regression is caused by:
commit 4327ba435a56ada13eedf3eb332e583c7a0586a9
bnx2: Fix netpoll crash.
If ->open() and ->close() are called multiple times, the same napi structs
will be added to dev->napi_list multiple times, corrupting the dev->napi_list.
This causes free_netdev() to hang during rmmod.
We fix this by calling netif_napi_del() during ->close().
Also, bnx2_init_napi() must not be in the __devinit section since it is
called by ->open().
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: Benjamin Li <benli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| drivers/net/bnx2.c | diffblobblamehistory |