| commit | f0a515780393dffbb363e6d1567da46af6f3c5f3 | |
| author | Sasha Levin <sasha.levin@oracle.com> | |
| Fri, 28 Aug 2015 11:06:58 +0000 (28 07:06 -0400) | ||
| committer | Steven Rostedt <rostedt@goodmis.org> | |
| Mon, 31 Aug 2015 14:47:14 +0000 (31 10:47 -0400) | ||
| tree | cad3408ace5cb1542a4eca314eaa847436ab0ff3 | treesnapshot (tar.gz zip) |
| parent | 9f61668073a8d80650622e792aff876db9ca23c6 | commitdiff |
tracing: Don't make assumptions about length of string on task rename
While the dest comm string size is assured to be at least TASK_COMM_LEN long,
doing a memcpy() also adds the assumption that the source is at least that
long as well, which isn't assured, and isn't true in cases such as:
set_task_comm(worker->task, "kworker/dying");
This leads to accessing invalid memory.
Link: http://lkml.kernel.org/r/1440760018-1557-1-git-send-email-sasha.levin@oracle.com
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
While the dest comm string size is assured to be at least TASK_COMM_LEN long,
doing a memcpy() also adds the assumption that the source is at least that
long as well, which isn't assured, and isn't true in cases such as:
set_task_comm(worker->task, "kworker/dying");
This leads to accessing invalid memory.
Link: http://lkml.kernel.org/r/1440760018-1557-1-git-send-email-sasha.levin@oracle.com
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
| include/trace/events/task.h | diffblobblamehistory |