| commit | f8da5dee0901ff291a1a99e2c37a23617d8a52ea | |
| author | Benjamin Coddington <bcodding@redhat.com> | |
| Fri, 2 Jun 2017 15:21:34 +0000 (2 11:21 -0400) | ||
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | |
| Wed, 5 Jul 2017 12:41:38 +0000 (5 14:41 +0200) | ||
| tree | f612baeb624f99aa62f07af34c63d0f93a8af511 | treesnapshot (tar.gz zip) |
| parent | f521e0bfcbff93128bffba99343f03c7873a538e | commitdiff |
NFSv4.2: Don't send mode again in post-EXCLUSIVE4_1 SETATTR with umask
commit 501e7a4689378f8b1690089bfdd4f1e12ec22903 upstream.
Now that we have umask support, we shouldn't re-send the mode in a SETATTR
following an exclusive CREATE, or we risk having the same problem fixed in
commit 5334c5bdac92 ("NFS: Send attributes in OPEN request for
NFS4_CREATE_EXCLUSIVE4_1"), which is that files with S_ISGID will have that
bit stripped away.
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Fixes: dff25ddb4808 ("nfs: add support for the umask attribute")
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
commit 501e7a4689378f8b1690089bfdd4f1e12ec22903 upstream.
Now that we have umask support, we shouldn't re-send the mode in a SETATTR
following an exclusive CREATE, or we risk having the same problem fixed in
commit 5334c5bdac92 ("NFS: Send attributes in OPEN request for
NFS4_CREATE_EXCLUSIVE4_1"), which is that files with S_ISGID will have that
bit stripped away.
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Fixes: dff25ddb4808 ("nfs: add support for the umask attribute")
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| fs/nfs/nfs4proc.c | diffblobblamehistory |