| commit | f9e628a6645ed4f42a15dfa3c5af45a916a228e4 | |
| author | Jia-Ju Bai <baijiaju1990@gmail.com> | |
| Wed, 11 Apr 2018 02:14:10 +0000 (11 10:14 +0800) | ||
| committer | Stefan Schmidt <stefan@osg.samsung.com> | |
| Mon, 23 Apr 2018 18:56:23 +0000 (23 20:56 +0200) | ||
| tree | 02e52473bc2968a3bc613a4ac1f9751a6bb0bba3 | treesnapshot (tar.gz zip) |
| parent | 94912e8df4e5005cb5fa3f3603741eb5e8bf3334 | commitdiff |
net: ieee802154: atusb: Replace GFP_ATOMIC with GFP_KERNEL in atusb_probe
atusb_probe() is never called in atomic context.
This function is only set as ".probe" in struct usb_driver.
Despite never getting called from atomic context,
atusb_probe() calls usb_alloc_urb() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
atusb_probe() is never called in atomic context.
This function is only set as ".probe" in struct usb_driver.
Despite never getting called from atomic context,
atusb_probe() calls usb_alloc_urb() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
| drivers/net/ieee802154/atusb.c | diffblobblamehistory |