[yaml2obj][obj2yaml] - Use a single "Other" field instead of "Other", "Visibility...
commit8ae026bea45429b14e0154bad0aad33530af80ff
authorGeorge Rimar <grimar@accesssoftek.com>
Fri, 30 Aug 2019 13:39:22 +0000 (30 13:39 +0000)
committerGeorge Rimar <grimar@accesssoftek.com>
Fri, 30 Aug 2019 13:39:22 +0000 (30 13:39 +0000)
treed2ec6f3bd8d371a2a188121e650e7e797878024d
parent62303d5d034f78f358b44a83fc4f47a42fb6861c
[yaml2obj][obj2yaml] - Use a single "Other" field instead of "Other", "Visibility" and "StOther".

Currenly we can encode the 'st_other' field of symbol using 3 fields.
'Visibility' is used to encode STV_* values.
'Other' is used to encode everything except the visibility, but it can't handle arbitrary values.
'StOther' is used to encode arbitrary values when 'Visibility'/'Other' are not helpfull enough.

'st_other' field is used to encode symbol visibility and platform-dependent
flags and values. Problem to encode it is that it consists of Visibility part (STV_* values)
which are enumeration values and the Other part, which is different and inconsistent.

For MIPS the Other part contains flags for all STO_MIPS_* values except STO_MIPS_MIPS16.
(Like comment in ELFDumper says: "Someones in their infinite wisdom decided to make
STO_MIPS_MIPS16 flag overlapped with other ST_MIPS_xxx flags."...)

And for PPC64 the Other part might actually encode any value.

This patch implements custom logic for handling the st_other and removes
'Visibility' and 'StOther' fields.

Here is an example of a new YAML style this patch allows:

- Name:  foo
  Other: [ 0x4 ]
- Name:  bar
  Other: [ STV_PROTECTED, 4 ]
- Name:  zed
  Other: [ STV_PROTECTED, STO_MIPS_OPTIONAL, 0xf8 ]

Differential revision: https://reviews.llvm.org/D66886

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@370472 91177308-0d34-0410-b5e6-96231b3b80d8
12 files changed:
include/llvm/ObjectYAML/ELFYAML.h
include/llvm/Support/YAMLTraits.h
lib/ObjectYAML/ELFEmitter.cpp
lib/ObjectYAML/ELFYAML.cpp
lib/Support/YAMLTraits.cpp
test/tools/llvm-objcopy/ELF/localize-hidden.test
test/tools/llvm-objcopy/ELF/symbol-copy.test
test/tools/llvm-objdump/elf-symbol-visibility.test
test/tools/llvm-readobj/elf-symbol-visibility.test
test/tools/obj2yaml/elf-symbol-visibility.yaml
test/tools/yaml2obj/elf-symbol-stother.yaml
test/tools/yaml2obj/elf-symbol-visibility.yaml