From a461b7a03cde32cd6560dcbcea23ec51dfd1e522 Mon Sep 17 00:00:00 2001 From: Eugene Leviant Date: Tue, 22 Oct 2019 12:57:23 +0000 Subject: [PATCH] [ThinLTO] Add code comment. NFC git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@375500 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/IPO/FunctionImport.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/Transforms/IPO/FunctionImport.cpp b/lib/Transforms/IPO/FunctionImport.cpp index 2ce8c92ec8a..3f5cc078d75 100644 --- a/lib/Transforms/IPO/FunctionImport.cpp +++ b/lib/Transforms/IPO/FunctionImport.cpp @@ -952,6 +952,9 @@ void llvm::thinLTOResolvePrevailingInModule( if (NewLinkage == GV.getLinkage()) return; if (GlobalValue::isLocalLinkage(GV.getLinkage()) || + // Don't internalize anything here, because the code below + // lacks necessary correctness checks. Leave this job to + // LLVM 'internalize' pass. GlobalValue::isLocalLinkage(NewLinkage) || // In case it was dead and already converted to declaration. GV.isDeclaration()) -- 2.11.4.GIT