| commit | fb6596f1ecab652b5b90cf2e395d64112504c1f8 | |
| author | Jeremy Morse <jeremy.morse@sony.com> | |
| Wed, 6 Apr 2022 10:50:51 +0000 (6 11:50 +0100) | ||
| committer | Jeremy Morse <jeremy.morse@sony.com> | |
| Wed, 6 Apr 2022 10:55:38 +0000 (6 11:55 +0100) | ||
| tree | b2e178b03419634acb3782d7aff857a15039cac3 | treesnapshot (tar.gz zip) |
| parent | 77c74fd877b27418171693f187b8db865567b8dc | commitdiff |
[DebugInfo][InstrRef] Avoid a crash from mixed variable location modes
Variable locations now come in two modes, instruction referencing and
DBG_VALUE. At -O0 we pick DBG_VALUE to allow fast construction of variable
information. Unfortunately, SelectionDAG edits the optimisation level in
the presence of opt-bisect-limit, meaning different passes have different
views of what variable location mode we should use. That causes assertions
when they're mixed.
This patch plumbs through a boolean in SelectionDAG from start to
instruction emission, so that we don't rely on the current optimisation
level for correctness.
Differential Revision: https://reviews.llvm.org/D123033
Variable locations now come in two modes, instruction referencing and
DBG_VALUE. At -O0 we pick DBG_VALUE to allow fast construction of variable
information. Unfortunately, SelectionDAG edits the optimisation level in
the presence of opt-bisect-limit, meaning different passes have different
views of what variable location mode we should use. That causes assertions
when they're mixed.
This patch plumbs through a boolean in SelectionDAG from start to
instruction emission, so that we don't rely on the current optimisation
level for correctness.
Differential Revision: https://reviews.llvm.org/D123033