| commit | fed564432cef76f8b303c19ab1dfc0a14878fbc3 | |
| author | Fangrui Song <i@maskray.me> | |
| Thu, 14 Dec 2023 19:03:28 +0000 (14 11:03 -0800) | ||
| committer | GitHub <noreply@github.com> | |
| Thu, 14 Dec 2023 19:03:28 +0000 (14 11:03 -0800) | ||
| tree | ffa392c614b3c37bfc7a30f962395e28642f5d9b | treesnapshot (tar.gz zip) |
| parent | 419c45a3252489d0ebac4535fe5a4ed9a6af6bbd | commitdiff |
[Sema] atomic_compare_exchange: check failure memory order (#74959)
For
`__atomic_compare_exchange{,_n}/__c11_atomic_compare_exchange_{strong,weak}`,
GCC checks both the success memory order and the failure memory order
under the default -Winvalid-memory-model ("memory model" is confusing
here and "memory order" is much more common in the atomic context).
* The failure memory order, if a constant, must be one of
relaxed/consume/acquire/seq_cst.
Clang checks just the success memory order under the default
-Watomic-memory-ordering. This patch checks the failure memory order.
For
`__atomic_compare_exchange{,_n}/__c11_atomic_compare_exchange_{strong,weak}`,
GCC checks both the success memory order and the failure memory order
under the default -Winvalid-memory-model ("memory model" is confusing
here and "memory order" is much more common in the atomic context).
* The failure memory order, if a constant, must be one of
relaxed/consume/acquire/seq_cst.
Clang checks just the success memory order under the default
-Watomic-memory-ordering. This patch checks the failure memory order.