From 43b7124c5749b3f3276adf1b869e623e163e230e Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 2 Feb 2025 09:31:06 -0800 Subject: [PATCH] [AST] Migrate away from PointerUnion::dyn_cast (NFC) (#125379) Note that PointerUnion::dyn_cast has been soft deprecated in PointerUnion.h: // FIXME: Replace the uses of is(), get() and dyn_cast() with // isa, cast and the llvm::dyn_cast This patch migrates the use of PointerUnion::dyn_cast to dyn_cast_if_present because the non-const variant of getInitializedFieldInUnion is known to encounter null in ArrayFillerOrUnionFieldInit. See: commit 563c7c5539f05e7f8cbb42565c1f24466019f38b Author: Kazu Hirata Date: Sat Jan 25 14:05:01 2025 -0800 FWIW, I am not aware of any test case in check-clang that triggers null here. --- clang/include/clang/AST/ExprCXX.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/include/clang/AST/ExprCXX.h b/clang/include/clang/AST/ExprCXX.h index 0b6c8cfb163c..98ba2bb41bb5 100644 --- a/clang/include/clang/AST/ExprCXX.h +++ b/clang/include/clang/AST/ExprCXX.h @@ -5040,7 +5040,7 @@ public: } const FieldDecl *getInitializedFieldInUnion() const { - return ArrayFillerOrUnionFieldInit.dyn_cast(); + return dyn_cast_if_present(ArrayFillerOrUnionFieldInit); } child_range children() { -- 2.11.4.GIT