From e65c5eebb8ed534b4575878e42e532389dcb5a2c Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 1 Dec 2022 12:06:31 -0800 Subject: [PATCH] [AArch64] Make opcode switch in tryARM64PackedUnwind comprehensive. I don't think compiler-generated code could actually be affected by this, but better to be thorough. Differential Revision: https://reviews.llvm.org/D139048 --- llvm/lib/MC/MCWin64EH.cpp | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/llvm/lib/MC/MCWin64EH.cpp b/llvm/lib/MC/MCWin64EH.cpp index 99722704ac50..5102d48b3a5d 100644 --- a/llvm/lib/MC/MCWin64EH.cpp +++ b/llvm/lib/MC/MCWin64EH.cpp @@ -999,6 +999,23 @@ static bool tryARM64PackedUnwind(WinEH::FrameInfo *info, uint32_t FuncLength, // These are never canonical; they don't show up with the usual Arm64 // calling convention. return false; + case Win64EH::UOP_AllocLarge: + // Allocations this large can't be represented in packed unwind (and + // usually don't fit the canonical form anyway because we need to use + // __chkstk to allocate the stack space). + return false; + case Win64EH::UOP_AddFP: + // "add x29, sp, #N" doesn't show up in the canonical pattern (except for + // N=0, which is UOP_SetFP). + return false; + case Win64EH::UOP_TrapFrame: + case Win64EH::UOP_Context: + case Win64EH::UOP_ClearUnwoundToCall: + case Win64EH::UOP_PushMachFrame: + // These are special opcodes that aren't normally generated. + return false; + default: + report_fatal_error("Unknown Arm64 unwind opcode"); } } if (RegI > 10 || RegF > 8) -- 2.11.4.GIT