From f4af616302e87a643c6954d336b0a2f0459e2640 Mon Sep 17 00:00:00 2001 From: Raymond Toy Date: Wed, 26 Jun 2024 05:08:43 -0700 Subject: [PATCH] Rename *ll* and *ul* to ll and ul in cv The function `cv` doesn't really need the special variables since they're arguments, so rename the args to `ll` and `ul` to break that connection. Full testsuite + share passes with cmucl and ccl64. --- src/defint.lisp | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/defint.lisp b/src/defint.lisp index 7683c9719..8169d9c5c 100644 --- a/src/defint.lisp +++ b/src/defint.lisp @@ -652,8 +652,8 @@ in the interval of integration.") ;; x = (b*y+a)/(y+1). ;; ;; (I'm guessing CV means Change Variable here.) -(defun cv (exp ivar *ll* *ul*) - (if (not (or (real-infinityp *ll*) (real-infinityp *ul*))) +(defun cv (exp ivar ll ul) + (if (not (or (real-infinityp ll) (real-infinityp ul))) ;; FIXME! This is a hack. We apply the transformation with ;; symbolic limits and then substitute the actual limits later. ;; That way method-by-limits (usually?) sees a simpler @@ -662,17 +662,17 @@ in the interval of integration.") ;; See Bugs 938235 and 941457. These fail because $FACTOR is ;; unable to factor the transformed result. This needs more ;; work (in other places). - (let ((trans (integrand-changevar (m// (m+t '*ll* (m*t '*ul* 'yx)) + (let ((trans (integrand-changevar (m// (m+t 'll (m*t 'ul 'yx)) (m+t 1. 'yx)) 'yx exp ivar))) ;; If the limit is a number, use $substitute so we simplify ;; the result. Do we really want to do this? - (setf trans (if (mnump *ll*) - ($substitute *ll* '*ll* trans) - (subst *ll* '*ll* trans))) - (setf trans (if (mnump *ul*) - ($substitute *ul* '*ul* trans) - (subst *ul* '*ul* trans))) + (setf trans (if (mnump ll) + ($substitute ll 'll trans) + (subst ll 'll trans))) + (setf trans (if (mnump ul) + ($substitute ul 'ul trans) + (subst ul 'ul trans))) (method-by-limits trans 'yx 0. '$inf)) ())) -- 2.11.4.GIT