| commit | 070b8b40fb9cc2b4912f9c1b06d93712c0b2ddf3 | |
| author | David Mudrák <david@moodle.com> | |
| Mon, 29 Jul 2013 13:09:25 +0000 (29 15:09 +0200) | ||
| committer | Matmarex <matma.rex@gmail.com> | |
| Mon, 29 Jul 2013 13:25:39 +0000 (29 13:25 +0000) | ||
| tree | 71d869d57a9b601dd508ea5c3404c26429100bb8 | treesnapshot (tar.gz zip) |
| parent | 882f25af96eba61e30ef97f2275e0885b4331565 | commitdiff |
updater: Move rev_sha1 addition before convertUserOptions
Execution of the script and addition of rev_sha1 are both 1.19
activities, but for some reason the issue has only shown up in 1.21.
* MysqlUpdater::getCoreUpdateList() declares that 'doMigrateUserOptions'
should be executed before adding the field rev_sha1 into the revision table
* ConvertUserOptions::execute() calls User::saveSettings()
* User::saveSettings() at its very end calls $this->getUserPage()->invalidateCache()
and that is where the revision query is joining the party.
Bug: 48820
Change-Id: Id0a6efc33a8c46fdc3e9c294aa2d005d46c7dda0
Execution of the script and addition of rev_sha1 are both 1.19
activities, but for some reason the issue has only shown up in 1.21.
* MysqlUpdater::getCoreUpdateList() declares that 'doMigrateUserOptions'
should be executed before adding the field rev_sha1 into the revision table
* ConvertUserOptions::execute() calls User::saveSettings()
* User::saveSettings() at its very end calls $this->getUserPage()->invalidateCache()
and that is where the revision query is joining the party.
Bug: 48820
Change-Id: Id0a6efc33a8c46fdc3e9c294aa2d005d46c7dda0
| includes/installer/MysqlUpdater.php | diffblobblamehistory |