| commit | b0a13b0595bffe29eb738201020af99e9141a068 | |
| author | Kosta Harlan <kharlan@wikimedia.org> | |
| Wed, 1 Feb 2023 10:43:40 +0000 (1 11:43 +0100) | ||
| committer | Jdlrobson <jrobson@wikimedia.org> | |
| Wed, 1 Feb 2023 22:50:01 +0000 (1 22:50 +0000) | ||
| tree | 244c85df71ca510aab21200fe860a2b20d84999f | treesnapshot (tar.gz zip) |
| parent | 5974a8839fd78619e4d3a86b2a45ba03eb2c3caf | commitdiff |
Adjust default targets in RL/Module
In Ia062ff2d8b8732b0d3498c1a614bbf6a3e3a7ddb, we changed the default
targets to desktop/mobile. This broke CI for PageTriage, which has a RL
module that extends ResourceLoader\Module, and which sets the default
targets for "desktop" only.
I am not sure if leaving ResourceLoader\Module as "desktop" only was a
deliberate choice or an oversight, but it seems to be more consistent to
have it defined as desktop/mobile. This will fix the issue for
PageTriage and other extensions that extend ResourceLoader\Module and
don't have any targets explicitly defined for their RL modules.
Follows-Up: Ia062ff2d8b8732b0d3498c1a614bbf6a3e3a7ddb
Bug: T127268
Bug: T328497
Change-Id: I48ed19912610a74af66d620510c192c7ba87039a
In Ia062ff2d8b8732b0d3498c1a614bbf6a3e3a7ddb, we changed the default
targets to desktop/mobile. This broke CI for PageTriage, which has a RL
module that extends ResourceLoader\Module, and which sets the default
targets for "desktop" only.
I am not sure if leaving ResourceLoader\Module as "desktop" only was a
deliberate choice or an oversight, but it seems to be more consistent to
have it defined as desktop/mobile. This will fix the issue for
PageTriage and other extensions that extend ResourceLoader\Module and
don't have any targets explicitly defined for their RL modules.
Follows-Up: Ia062ff2d8b8732b0d3498c1a614bbf6a3e3a7ddb
Bug: T127268
Bug: T328497
Change-Id: I48ed19912610a74af66d620510c192c7ba87039a
| includes/ResourceLoader/FileModule.php | diffblobblamehistory | |
| includes/ResourceLoader/Module.php | diffblobblamehistory |