| commit | e2522e7e7eafdc0a2ca36e1f7f681562b580b355 | |
| author | Brad Jorsch <bjorsch@wikimedia.org> | |
| Fri, 3 Jun 2016 15:33:41 +0000 (3 11:33 -0400) | ||
| committer | Brad Jorsch <bjorsch@wikimedia.org> | |
| Fri, 3 Jun 2016 15:37:29 +0000 (3 11:37 -0400) | ||
| tree | 6202082b61178c830ff4230e2e5b720d0c113ade | treesnapshot (tar.gz zip) |
| parent | 089612544da3abd89476f41476abc78b0cd98e98 | commitdiff |
Don't override action in UI and REDIRECT responses
In Ic8caf57eb, we changed things so the requests returned in a UI or
REDIRECT response would have the action forced to that appropriate for
the action being peformed. But ResetPasswordSecondaryAuthenticationProvider
has a use case where a mismatch is necessary: it's run during the login
action, but it needs a PasswordAuthenticationResponse for a change
action.
Bug: T136894
Change-Id: I9d109a22c5b2d2064f664f584100ecaab43199c5
In Ic8caf57eb, we changed things so the requests returned in a UI or
REDIRECT response would have the action forced to that appropriate for
the action being peformed. But ResetPasswordSecondaryAuthenticationProvider
has a use case where a mismatch is necessary: it's run during the login
action, but it needs a PasswordAuthenticationResponse for a change
action.
Bug: T136894
Change-Id: I9d109a22c5b2d2064f664f584100ecaab43199c5
| includes/auth/AuthManager.php | diffblobblamehistory | |
| includes/auth/ResetPasswordSecondaryAuthenticationProvider.php | diffblobblamehistory |