| commit | ed542f41daf10f336a9d32107246dc7394ebfb12 | |
| author | Oren Held <oren@held.org.il> | |
| Sat, 25 May 2013 10:59:13 +0000 (25 13:59 +0300) | ||
| committer | Oren Held <oren@held.org.il> | |
| Sat, 25 May 2013 10:59:13 +0000 (25 13:59 +0300) | ||
| tree | 9f194d800f0fc3e785be2639f8b2741aaa11c369 | treesnapshot (tar.gz zip) |
| parent | 775cd3c0eb92b8ef65c3d0e6af6126d008e7319f | commitdiff |
Installer: page refresh should refresh list of supported DBs
There's no need to cache _CompiledDBs's value from the first installer load.
Instead, the list should be regenerated on every page load, as it's merely being
used for displaying the user list of DBs to choose from.
This solves a common setup confusion, where user starts with no DB support, gets
a friendly error message, installs php5-mysql as requested, but refreshing the
page won't make the error go away.
Bug: 31533
Change-Id: I2e7e5b4f72e7c11706d491a205e202008e2511da
There's no need to cache _CompiledDBs's value from the first installer load.
Instead, the list should be regenerated on every page load, as it's merely being
used for displaying the user list of DBs to choose from.
This solves a common setup confusion, where user starts with no DB support, gets
a friendly error message, installs php5-mysql as requested, but refreshing the
page won't make the error go away.
Bug: 31533
Change-Id: I2e7e5b4f72e7c11706d491a205e202008e2511da
| includes/installer/Installer.php | diffblobblamehistory | |
| includes/installer/WebInstallerPage.php | diffblobblamehistory |