| commit | eef8fc45f3d03596579abb2519185ace38cf6832 | |
| author | Aaron Schulz <aschulz@wikimedia.org> | |
| Tue, 25 Oct 2016 18:56:41 +0000 (25 11:56 -0700) | ||
| committer | Aaron Schulz <aschulz@wikimedia.org> | |
| Sat, 29 Oct 2016 00:13:56 +0000 (28 17:13 -0700) | ||
| tree | cfd1d332e6dded90d26c77fbb33c36cbc71daf37 | treesnapshot (tar.gz zip) |
| parent | dc0f9b3a3a75e80a0c5f09dd76b4df1fcc05080d | commitdiff |
Postgres updater fixes to make update.php able to run
* Remove redundant schema prefix from relname=x query. The
schema filtering is already done via the JOIN. The relname
portion is just the table name not <schema>.<table name>.
* Avoid explicit table schema qualification and rely on the
search path, as MW 1.27 did. Previously it only used the
global $wgDBschema var to pass to determineCoreSchema()
instead of keeping it in mSchema.
* Clean up some code duplication in Database::tableName() and
make the code comments clearer.
* Make DatabasePostgres::tableName() use parent::tableName()
instead of a method that just wraps this method. The intent
seems clearer this way.
* Remove unused return value in
PostgresUpdater::rebuildTextSearch().
Bug: T148628
Change-Id: Id11d9576b7c2fdad22ff7f90727c12997217a632
* Remove redundant schema prefix from relname=x query. The
schema filtering is already done via the JOIN. The relname
portion is just the table name not <schema>.<table name>.
* Avoid explicit table schema qualification and rely on the
search path, as MW 1.27 did. Previously it only used the
global $wgDBschema var to pass to determineCoreSchema()
instead of keeping it in mSchema.
* Clean up some code duplication in Database::tableName() and
make the code comments clearer.
* Make DatabasePostgres::tableName() use parent::tableName()
instead of a method that just wraps this method. The intent
seems clearer this way.
* Remove unused return value in
PostgresUpdater::rebuildTextSearch().
Bug: T148628
Change-Id: Id11d9576b7c2fdad22ff7f90727c12997217a632